textanalyze: fixes path handling in windows as well #162
Conversation
|
Thanks! |
|
|
||
| func analyzeTextAnalyze(analyzer *troubleshootv1beta1.TextAnalyze, getCollectedFileContents func(string) ([]byte, error)) (*AnalyzeResult, error) { | ||
| fullPath := path.Join(analyzer.CollectorName, analyzer.FileName) | ||
| fullPath := filepath.Join(analyzer.CollectorName, analyzer.FileName) |
There was a problem hiding this comment.
@CodeLingoBot capture avoid path.Join
path.Join only works for paths separated by forward slashes. This can be problematic on Windows. Use filepath.Join to create paths in a way that is compatible with the target operating systems defined file paths.
There was a problem hiding this comment.
Rule captured at https://dash.codelingo.io/repos/replicatedhq/troubleshoot/rules/1403
CodeLingoBot Help
When responding to PR-level comments, I understand the following commands:
-
captureto capture the context for a fresh rule. -
reviewto trigger a fresh review.
When responding to comments on specific lines of code, I understand the following commands:
-
captureto capture the context for a fresh rule. -
reviewto trigger a fresh review. -
ignoreto ignore the parent review comment. -
unignoreto stop ignoring a parent review comment.
4 participants
Fixes a situation where path was not built appropriately for windows