Skip to content

Conversation

@JGAntunes
Copy link
Member

@JGAntunes JGAntunes commented Oct 8, 2025

What this PR does / why we need it:

  • Persists state to session storage with the current installer steps we're at so that refreshing moves us back to the point we left of.
  • Moves mutations that happened on component mount to the previous actionable button.

Loom illustrating the fix:

Which issue(s) this PR fixes:

And it unblocks solving - https://app.shortcut.com/replicated/story/129776/unable-to-run-app-preflights-because-lock-is-not-released-new-installer - albeit to fully address it some further work is still required.

It actually fixes - https://app.shortcut.com/replicated/story/129776/unable-to-run-app-preflights-because-lock-is-not-released-new-installer - too now.

Does this PR require a test?

Added

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@JGAntunes JGAntunes self-assigned this Oct 8, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-a01cb67" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-a01cb67?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

});

// Mutation for starting app preflights
const { mutate: startAppPreflights, error: startAppPreflightsError } = useMutation({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we should move these to a mutations / queries directory so it can be re-used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, IMO we should move the fetch calls to its own package and then have each component use react query as its suits them as a wrapper around said fetch methods.

sgalsaleh
sgalsaleh previously approved these changes Oct 9, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it's valuable to have this test file, we're just gonna remove it right after this pr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a cheap set of tests tbh, it's also already here. Deleting them would be more work now 😅 but up to you, if you consider this a deal breaker I can delete them, no strong feelings.

@JGAntunes JGAntunes merged commit f2671bb into main Oct 10, 2025
209 of 218 checks passed
@JGAntunes JGAntunes deleted the jgantunes/sc-124347/the-state-of-the-installation-progress-is branch October 10, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants