-
Notifications
You must be signed in to change notification settings - Fork 8
feat(web): perserve installation progress #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): perserve installation progress #3022
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
| }); | ||
|
|
||
| // Mutation for starting app preflights | ||
| const { mutate: startAppPreflights, error: startAppPreflightsError } = useMutation({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we should move these to a mutations / queries directory so it can be re-used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, IMO we should move the fetch calls to its own package and then have each component use react query as its suits them as a wrapper around said fetch methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think it's valuable to have this test file, we're just gonna remove it right after this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a cheap set of tests tbh, it's also already here. Deleting them would be more work now 😅 but up to you, if you consider this a deal breaker I can delete them, no strong feelings.
What this PR does / why we need it:
Loom illustrating the fix:
Which issue(s) this PR fixes:
And it unblocks solving - https://app.shortcut.com/replicated/story/129776/unable-to-run-app-preflights-because-lock-is-not-released-new-installer - albeit to fully address it some further work is still required.It actually fixes - https://app.shortcut.com/replicated/story/129776/unable-to-run-app-preflights-because-lock-is-not-released-new-installer - too now.
Does this PR require a test?
Added
Does this PR require a release note?
Does this PR require documentation?
NONE