Handle todos #85
Merged
Handle todos #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasjansson
force-pushed
the
andreas/handle-todos
branch
2 times, most recently
from
f68b999 to
d661566
Compare
bfirsh
approved these changes
May 21, 2021
Member
bfirsh
left a comment
bfirsh
left a comment
There was a problem hiding this comment.
Great! Some minor things, but nothing blocking merging.
This is based on #82 which I'm not sure is intentional or not. Happy to include that if you want to get it in and we can iterate, otherwise might want to base this on main if we want to review that separately.
andreasjansson
force-pushed
the
andreas/handle-todos
branch
from
d661566 to
d7cc165
Compare
Member
Author
Signed-off-by: andreasjansson <[email protected]>
Signed-off-by: andreasjansson <[email protected]>
Signed-off-by: andreasjansson <[email protected]>
Signed-off-by: andreasjansson <[email protected]>
Signed-off-by: andreasjansson <[email protected]>
Signed-off-by: andreasjansson <[email protected]>
Signed-off-by: andreasjansson <[email protected]>
andreasjansson
force-pushed
the
andreas/handle-todos
branch
6 times, most recently
from
a099674 to
d61068f
Compare
Signed-off-by: andreasjansson <[email protected]>
andreasjansson
force-pushed
the
andreas/handle-todos
branch
from
d61068f to
7bd2e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle various TODOs, broken up into individual commits.