Skip to content

Conversation

@bfirsh
Copy link
Member

@bfirsh bfirsh commented May 19, 2021

giphy

Somewhat hesitant to put it in make test because that slows down the development cycle. Mayeb we can set up pre-commit or something.

Signed-off-by: Ben Firshman <[email protected]>
@bfirsh
Copy link
Member Author

bfirsh commented May 19, 2021

Also I removed --local from goimports because that can't be configured from vscode. Weirdly though it does it correctly if there are already some local imports, so in practice it'll keep the local ones sorted locally. This just avoids some annoying back and forths I had in Keepsake where the CI was doing goimports differently to how my editor was.

@andreasjansson
Copy link
Member

👍

@andreasjansson andreasjansson merged commit 36812af into replicate:main May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants