Update web hooks #74
Merged
Update web hooks #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks great! I'm not sure I fully understand what the hooks are for without looking into it in more detail though. (e.g. What is the difference between a "primary" and "non-primary" hook?) Perhaps needs documentation? Also needs a rebase sorry :) |
* Run "post-build" hook before "post-build-primary" hook * Include image URI and arch Signed-off-by: andreasjansson <[email protected]>
andreasjansson
force-pushed
the
andreas/update-webhooks
branch
from
73d828b to
764f031
Compare
Member
|
Still missing docs. Unless you think we don't need it? |
Member
Author
|
@bfirsh there's a TODO in there to add docs, i'll add that later. it might still move around a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: andreasjansson [email protected]