Skip to content

Catch error when server dies to avoid spewing logs #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreasjansson merged 1 commit into from
May 4, 2021
Merged

Catch error when server dies to avoid spewing logs #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/client/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,11 @@ func (c *Client) UploadModel(repo *model.Repo, projectDir string) (*model.Model,
break
}
if err == io.ErrUnexpectedEOF {
console.Warn("Unexpected EOF")
break
return nil, fmt.Errorf("Unexpected EOF")
}
// TODO(andreas): how to catch this error without comparing strings?
if strings.Contains(err.Error(), "stream error") && strings.Contains(err.Error(), "INTERNAL_ERROR") {
return nil, fmt.Errorf("Lost contact with server. Please try again")
}
console.Warn(err.Error())
}
Expand Down