feat: add registry migration support with credential fallback #2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements DP-682 to support registry migration testing for internal teams. Changes: - Add COG_REGISTRY_HOST environment variable support for persistent registry override - Add --registry global persistent flag (hidden) for one-off overrides - Implement credential fallback: when alternate registry has no credentials, automatically reuse r8.im credentials - Update API client to dynamically load registry authentication - Update login messages to show actual registry host being authenticated Configuration priority: 1. --registry flag (highest - one-off overrides) 2. COG_REGISTRY_HOST env var (session/testing) 3. Default "r8.im" (lowest - production) This enables internal testing workflows like: export COG_REGISTRY_HOST=registry.r8.im cog login cog push registry.r8.im/user/model With credential fallback, existing r8.im credentials are automatically reused for alternate registries, showing: "Using existing r8.im credentials for <host>"
markphelps
requested review from
8W9aG,
michaeldwan and
tempusfrangit
and removed request for
8W9aG
There was a problem hiding this comment.
I don't see anything fundamentally wrong here but I'll be honest, I'm having a hard time following the some parts of the change, e.g. where some of the logging/defaults may have gone.
Can we add a test to show previous behavior[s] in absence of a config is maintained? It would make me feel a lot better about this change.
- Restore "you may need to authenticate using cog login" message in api_client.go - Add comprehensive tests for credential fallback behavior in credentials_test.go - Tests verify: - Direct credentials are used when available - Fallback to default registry credentials for alternate registries - No fallback occurs when requesting default registry - Direct credentials preferred over fallback - Proper error handling when no credentials available
Signed-off-by: Mark Phelps <[email protected]>
Move ctx parameter to first position in tryLoadAuthForHost function signature to follow Go convention (ctx should always be the first argument).
michaeldwan
approved these changes
Oct 1, 2025
markphelps
deleted the
dp-682-implement-registry-migration-support-in-cog-credential
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for other registries besides hardcoded
r8.imChanges
COG_REGISTRY_HOSTenvironment variable for persistent registry override--registryglobal persistent flag (hidden) for one-off overridesr8.imcredentialsConfiguration Priority
Usage
Internal teams can now test alternate registries:
Credential Fallback
Existing
r8.imcredentials are automatically reused for alternate registries, displaying:Testing
r8.imbehavior unchangedx.r8.im