-
Notifications
You must be signed in to change notification settings - Fork 641
Add integration test for setup run in trainer #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c0c0ff3
Add integration test for setup run in trainer
8W9aG d66da91
Fix test_train
8W9aG a3043c3
Fix tests
8W9aG 92c1127
Increase timeout
8W9aG a2c129e
Change message based on intent
8W9aG e55e542
Capture stderr properly
8W9aG 3aa0815
Fix check in string
8W9aG b38e7df
Fix weights test
8W9aG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
test-integration/test_integration/fixtures/training-setup-project/cog.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| build: | ||
| python_version: "3.12" | ||
| train: "train.py:Trainer" | ||
| predict: "predict.py:Predictor" |
6 changes: 6 additions & 0 deletions
6
test-integration/test_integration/fixtures/training-setup-project/predict.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| from cog import BasePredictor | ||
|
|
||
|
|
||
| class Predictor(BasePredictor): | ||
| def predict(self, s: str) -> str: | ||
| return "hello " + s |
14 changes: 14 additions & 0 deletions
14
test-integration/test_integration/fixtures/training-setup-project/train.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| from cog import BasePredictor | ||
|
|
||
|
|
||
| class Trainer(BasePredictor): | ||
| def setup(self) -> None: | ||
| print("Trainer is setting up.") | ||
|
|
||
| def train(self, s: str) -> str: | ||
| print("Trainer.train called.") | ||
| return "hello train " + s | ||
|
|
||
| def predict(self, s: str) -> str: | ||
| print("Trainer.predict called.") | ||
| return "hello predict " + s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!