Skip to content

Build the image on predict in fast boots #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8W9aG merged 3 commits into from
May 6, 2025
Merged

Build the image on predict in fast boots #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99a5017
Build the image on predict in fast boots
8W9aG May 6, 2025
e313adf
Remove redundant build phase
8W9aG May 6, 2025
38832ae
Change capture to text
8W9aG May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/cli/predict.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ func cmdPredict(cmd *cobra.Command, args []string) error {

if buildFast {
imageName = config.DockerImageName(projectDir)
if err := image.Build(ctx, cfg, projectDir, imageName, buildSecrets, buildNoCache, buildSeparateWeights, buildUseCudaBaseImage, buildProgressOutput, buildSchemaFile, buildDockerfileFile, DetermineUseCogBaseImage(cmd), buildStrip, buildPrecompile, buildFast, nil, buildLocalImage, dockerCommand); err != nil {
return err
}
} else {
if imageName, err = image.BuildBase(ctx, cfg, projectDir, buildUseCudaBaseImage, DetermineUseCogBaseImage(cmd), buildProgressOutput); err != nil {
return err
Expand Down
13 changes: 13 additions & 0 deletions test-integration/test_integration/test_predict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,3 +542,16 @@ def test_predict_granite_project(docker_image):
)
assert result.returncode == 0
assert result.stdout == "2.11.3\n"


def test_predict_fast_build(docker_image):
project_dir = Path(__file__).parent / "fixtures/fast-build"

result = subprocess.run(
["cog", "predict", "--x-fast", "-i", "s=world"],
cwd=project_dir,
capture_output=True,
text=True,
)
assert result.returncode == 0
assert result.stdout == "hello world\n"