move docker.Build to command.Command

[michaeldwan]

1. Move docker.Build to command.Command.Build.
2. Replace docker.Build calls from image.Build, cli/predict, and cli/baseImage with calls to Build on command.Command.
3. Move docker.BuildAddLabelsAndSchemaToImage to image.BuildAddLabelsAndSchemaToImage since the image package does all the other build coordination and this is no different.

[Copilot]

Pull Request Overview

This PR refactors the build process by moving the docker.Build functionality into the command.Command interface and updating all callers accordingly. Key changes include:

• Replacing docker.Build calls with dockerCommand.ImageBuild calls using a new ImageBuildOptions struct.
• Moving BuildAddLabelsAndSchemaToImage into the image package and updating its usage.
• Updating CLI commands (train, serve, run, predict, baseimage) to use the new dockerCommand implementation.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/image/openapi_schema.go	Commented out an unused function to be removed in a future PR.
pkg/image/build.go	Updated build flows to use the new dockerCommand.ImageBuild API and removed deprecated code.
pkg/docker/dockertest/mock_command.go	Added a stub for the new ImageBuild method in the mock implementation.
pkg/docker/docker_command.go	Updated multiple methods to use the new argument patterns and improved command execution.
pkg/docker/command/command.go	Extended the Command interface to include ImageBuild and updated the options struct.
pkg/docker/build.go	Removed the old docker.Build implementation as it’s now deprecated.
pkg/cli/*	Updated CLI commands to pass dockerCommand to build functions instead of constructing a new one.

Comments suppressed due to low confidence (1)

pkg/docker/dockertest/mock_command.go:97

• The new ImageBuild method added to the Command interface is currently a stub in the mock implementation. It is recommended to implement a simple behavior or add test coverage to ensure that build flows relying on ImageBuild behave as expected in tests.

func (c *MockCommand) ImageBuild(ctx context.Context, options command.ImageBuildOptions) error {

[Copilot]

[nitpick] Since the ImageBuild function now always forces '--platform linux/amd64' and conditionally adds '--load' for Apple Silicon, it might be useful to add inline comments clarifying the rationale for these options for future maintainers.

Suggested change

	// Fixes "WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested"
	// We do this regardless of the host platform so windows/*. linux/arm64, etc work as well
	"--platform", "linux/amd64",
	}
	if util.IsAppleSiliconMac(runtime.GOOS, runtime.GOARCH) {
	args = append(args,
	// buildx doesn't load images by default, so we tell it to load here. _however_, the
	// --output type=docker,rewrite-timestamp=true flag also loads the image, this may not be necessary
	// Ensures the build is compatible with the linux/amd64 platform, which is widely supported across different environments.
	// This avoids warnings like "The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8)"
	// and ensures consistent behavior regardless of the host platform (e.g., Windows, Linux ARM64, etc.).
	"--platform", "linux/amd64",
	}
	if util.IsAppleSiliconMac(runtime.GOOS, runtime.GOARCH) {
	args = append(args,
	// On Apple Silicon Macs, `--load` is necessary to load the built image into the local Docker daemon.
	// Note: The `--output type=docker,rewrite-timestamp=true` option also loads the image, so this may be redundant.
	// However, we include it here explicitly to ensure compatibility and clarity.

[8W9aG]

This is such an amazing change, thanks for doing this!