Skip to content

Conversation

@michaeldwan
Copy link
Member

@michaeldwan michaeldwan commented Apr 28, 2025

Just some housekeeping:

  1. upgrade go to 1.24. I'm doing work on context propagation and I wanted 1.24's testing.Context()
  2. golangci-lint was throwing errors about missing packages, and upgrading it via the url in Makefile failed after their v2 release. So I replaced tools.go and go run <url> commands in the Makefile with go 1.24's go get -tool and go tool <name> bits. Haven't used it yet, but seems like a nice qol change

@michaeldwan michaeldwan marked this pull request as ready for review April 28, 2025 15:41
@michaeldwan michaeldwan requested a review from Copilot April 28, 2025 17:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project's Go version to 1.24 and updates the dependency installation instructions accordingly.

  • Updated Go version documentation in CONTRIBUTING.md
  • Adjusted installation instructions to reflect support for Go 1.24
Files not reviewed (3)
  • .tool-versions: Language not supported
  • Makefile: Language not supported
  • go.mod: Language not supported

@michaeldwan michaeldwan requested a review from a team April 28, 2025 17:08
Copy link
Contributor

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@michaeldwan michaeldwan merged commit 5b547d2 into main Apr 28, 2025
21 checks passed
@michaeldwan michaeldwan deleted the md/upgrade-go branch April 28, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants