fix: Requirements format parser #2281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Fairs <[email protected]>
Signed-off-by: Dan Fairs <[email protected]>
Contributor
|
Thanks for this @danfairs ! The implementation and test look great, I'll see if we can get this in |
Contributor
|
Moved the PR to #2292 and merged it, will close now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the requirements file parser to improve very long line handling. Previously, lines (including continuations) that were longer than the data chunk that
scanner.Text()passed in (4096 bytes) would be truncated at the boundary. This caused invalid requirements files to be generated, as was observed in #2280.I have added a test which failed with the old code, but passes with the new code. My own problematic image also proceeds past the requirements generation step.
It would be good if a few other people could confirm this works on their images. I only have one - the first one I built with
cogran into this problem!