Remove checks for static schema #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Mar 28, 2025
8W9aG
commented
- Static schema checks are now made redundant by Pydantic 2.11 adding in additional metadata
- Use the tests to check for targeted dictionary equality instead.
* Static schema checks are now made redundant by Pydantic 2.11 adding in additional metadata * Use the tests to check for targeted dictionary equality instead.
michaeldwan
approved these changes
Mar 28, 2025
Member
michaeldwan
left a comment
michaeldwan
left a comment
There was a problem hiding this comment.
lgtm, though I don't trust my judgement yet.
Also, the web.TestDoFileChallenge test in go failed on ubuntu, but succeeded after I retried it. I don't think it's related though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.