Create scanner for removing comments and continuations #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Mar 27, 2025
8W9aG
commented
- When reading the requirements txt, handle line continuations and remove comments
* When reading the requirements txt, handle line continuations and remove comments
aron
reviewed
Mar 27, 2025
aron
reviewed
Mar 27, 2025
aron
reviewed
Mar 27, 2025
aron
suggested changes
Mar 27, 2025
Contributor
aron
left a comment
aron
left a comment
There was a problem hiding this comment.
Thanks for fixing this! In general the approach looks great. Before we merge I'd like to see tests for CRLF line endings and full line comments just to complete the coverage.
Co-authored-by: Aron Carroll <[email protected]> Signed-off-by: Will Sackfield <[email protected]>
* Scanner exits when the token is nil on return
aron
approved these changes
Mar 31, 2025
Contributor
aron
left a comment
aron
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.