Skip to content

Lock stream logger to be safe #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreasjansson merged 1 commit into from
Mar 29, 2021
+4 −1
Merged

Lock stream logger to be safe #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/logger/stream_logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import (
"encoding/json"
"fmt"
"net/http"
"sync"

"github.com/replicate/cog/pkg/console"

"github.com/replicate/cog/pkg/model"
)

Expand All @@ -28,6 +28,7 @@ type Message struct {

type StreamLogger struct {
writer http.ResponseWriter
mu sync.Mutex
}

func NewStreamLogger(w http.ResponseWriter) *StreamLogger {
Expand All @@ -45,6 +46,8 @@ func (logger *StreamLogger) logText(messageType MessageType, text string) {

func (logger *StreamLogger) write(data []byte) {
data = append(data, '\n')
logger.mu.Lock()
defer logger.mu.Unlock()
if _, err := logger.writer.Write(data); err != nil {
console.Warn("HTTP response writer failed to write: %s", data)
return
Expand Down