Skip to content

Add convenient functions #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbmc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add convenient functions #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions library/src/main/java/com/rengwuxian/materialedittext/MaterialEditText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,14 @@ public MaterialEditText(Context context, AttributeSet attrs, int style) {
init(context, attrs);
}

public String getString() {
return getText().toString().trim();
Copy link

@carlonzo carlonzo Aug 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not trim here. its not responsibility of the the met

Copy link
Author

@mbmc mbmc Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTrimmedString instead?

Copy link

@carlonzo carlonzo Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not put it at all (my point of view). this is an edittext, it should not care about how you want to handle the string typed

Copy link
Author

@mbmc mbmc Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but when you deal with user profile forms, you need to trim the strings. Either by extending MET, or creating a static function.

Copy link

@carlonzo carlonzo Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are free to do that on your side. what about if I need to get space the user has typed?

}

public boolean isEmpty() {
return TextUtils.isEmpty(getString());
Copy link

@carlonzo carlonzo Aug 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getString().isEmpty()

Copy link
Author

@mbmc mbmc Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isEmpty only available API 9+

Copy link

@carlonzo carlonzo Aug 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you right! wow! I didnt know that!

}

private void init(Context context, AttributeSet attrs) {
iconSize = getPixel(32);
iconOuterWidth = getPixel(48);
Expand Down