Call the controller method with the right context #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
purusho
commented
Mar 11, 2015
purusho
commented
- The controller was called with the wrong context.
- Some variable changes
- Added unit test
- Unit test code cleanup
Contributor
Author
|
Any update on merging this PR ? |
Member
|
@rendrjs/maintainers Is there anything missing from this PR that prevents it from merging? We'd like to go ahead with our changes. Thank you. |
Contributor
|
👍 sorry didn't see this PR. |
saponifi3d
added a commit
that referenced
this pull request
Mar 18, 2015
Call the controller method with the right context
Contributor
|
@alexindigo @purusho fyi - i just released version 1.0.2 which includes these changes (and the other PRs you've made) 👯 thanks for all the work on it! |
Member
|
Thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.