Load controller from action for AMD version #448
Conversation
|
+1 |
shared/base/router.js
Outdated
There was a problem hiding this comment.
Looks like realAction is a function (object) and requireAMD expects list of strings as dependencies.
There was a problem hiding this comment.
No, for an AMD app we are getting a string : https://github.com/purusho/rendr/blob/master/shared/base/router.js#L89
There was a problem hiding this comment.
Then let's check for the variable type, which will protect us from changes down the road
and will allow more flexible treatment of AMD environment on the server.
|
👍 @rendrjs/maintainers LGTM |
|
Seems good - can you please add a few tests around this? |
|
test added. |
There was a problem hiding this comment.
Have you tried to run actual app with this change?
There was a problem hiding this comment.
yes, and it's working.
|
Aw yeah! 83% coverage! We're gettin' there! |
Load controller from action for AMD version
5 participants
This PR will fix the loading of controllers for the AMD version.
Sample App's PR : rendrjs/rendr-examples#15