bug fix for backbone overriding the creation of a model #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This was how I was think we could work around this problem, but would love to hear if anyone else has a different idea. @saponifi3d can we add a simple test? |
shared/base/view.js
Outdated
added 2 commits
August 26, 2014 10:48
…ure everything is being passed correctly
Contributor
|
👍 increased test coverage! |
saponifi3d
added a commit
that referenced
this pull request
Aug 26, 2014
bug fix for backbone overriding the creation of a model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty quick fix - one line change.
The
parseOptionsalready does work to setthis.modelandthis.collectionbut the BaseView constructor will then override them. This will set it so it never overrides the two special cases in the base rendr view.