Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
23 changes: 23 additions & 0 deletions docs/archive/priority2-track-d/build-frontend-after.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
yarn run v1.22.22
$ vite build --config ./vite.config.ts
The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
7:58:50 PM [vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.

[email protected]

Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.
vite v5.4.21 building for production...
transforming...
✓ 98 modules transformed.
rendering chunks...
computing gzip size...
../../dist/icebreakers/index.html 7.20 kB │ gzip: 2.08 kB
../../dist/index.html 8.61 kB │ gzip: 2.59 kB
../../dist/css/simple-comment-style.css 11.68 kB │ gzip: 2.13 kB
../../dist/js/index.js 0.32 kB │ gzip: 0.25 kB │ map: 0.68 kB
../../dist/js/icebreakers.js 0.57 kB │ gzip: 0.37 kB │ map: 1.31 kB
../../dist/assets/modulepreload-polyfill-B5Qt9EMX.js 0.77 kB │ gzip: 0.44 kB │ map: 0.12 kB
../../dist/js/simple-comment-icebreakers.js 0.98 kB │ gzip: 0.58 kB │ map: 3.94 kB
../../dist/js/simple-comment.js 163.66 kB │ gzip: 51.73 kB │ map: 586.02 kB
✓ built in 5.57s
Done in 26.52s.
25 changes: 25 additions & 0 deletions docs/archive/priority2-track-d/build-frontend-baseline.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
yarn run v1.22.22
$ vite build --config ./vite.config.ts
The CJS build of Vite's Node API is deprecated. See https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
7:53:19 PM [vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.

[email protected]

Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.
vite v5.4.21 building for production...

/css/simple-comment-style.css doesn't exist at build time, it will remain unchanged to be resolved at runtime
transforming...
✓ 98 modules transformed.
rendering chunks...
computing gzip size...
../../dist/icebreakers/index.html 7.20 kB │ gzip: 2.08 kB
../../dist/index.html 8.61 kB │ gzip: 2.59 kB
../../dist/css/simple-comment-style.css 11.68 kB │ gzip: 2.13 kB
../../dist/js/index.js 0.32 kB │ gzip: 0.25 kB │ map: 0.68 kB
../../dist/js/icebreakers.js 0.57 kB │ gzip: 0.37 kB │ map: 1.31 kB
../../dist/assets/modulepreload-polyfill-B5Qt9EMX.js 0.77 kB │ gzip: 0.44 kB │ map: 0.12 kB
../../dist/js/simple-comment-icebreakers.js 0.98 kB │ gzip: 0.58 kB │ map: 3.94 kB
../../dist/js/simple-comment.js 163.66 kB │ gzip: 51.73 kB │ map: 586.02 kB
✓ built in 7.10s
Done in 26.74s.
114 changes: 114 additions & 0 deletions docs/archive/priority2-track-d/remediation-candidate-note.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
# Priority 2 Track D Remediation Candidate Note

Source artifacts:
- `docs/archive/priority2-track-d/build-frontend-baseline.log`
- `docs/archive/priority2-track-d/warning-register-current.md`

## Candidate Ranking

### 1. Stylesheet-path mitigation

- Scope surfaces:
- `vite.config.ts`
- `src/entry/index.html`
- `src/entry/icebreakers/index.html`
- Warning target:
- `/css/simple-comment-style.css doesn't exist at build time, it will remain unchanged to be resolved at runtime`
- Risk class:
- `MEDIUM`
- Why it ranks first:
- This is the primary repo-local mitigation candidate in the Track D plan.
- The warning comes from repo-owned HTML/Vite entry handling rather than third-party package metadata.
- The built output currently still emits the expected `/css/simple-comment-style.css` link in `dist/index.html` and `dist/icebreakers/index.html`, so the problem is build-output noise/clarity rather than an obvious broken artifact contract.
- Candidate directions:
- Prefer a narrow build-aware HTML/config alignment that preserves the existing `dist/css/simple-comment-style.css` contract.
- Avoid any change that requires broad frontend entry refactoring or changes embed/runtime behavior.
- Expected benefit:
- Possible removal of the only clearly repo-owned frontend build warning/noise signature.
- Main risk:
- A misguided fix could change built HTML asset references or stylesheet loading behavior without meaningfully improving user-facing behavior.

### 2. Low-risk Vite-config alignment

- Scope surfaces:
- `vite.config.ts`
- `package.json` scripts only if absolutely required by a low-risk repo-local config-loading adjustment
- Warning target:
- `The CJS build of Vite's Node API is deprecated.`
- Risk class:
- `MEDIUM-HIGH`
- Why it ranks second:
- The plan allows this notice to remain documented unless a genuinely low-risk repo-local fix exists.
- Likely remediation paths are closer to toolchain/config-loading alignment than to output-contract repair.
- This has more modernization spillover risk than the stylesheet-path notice.
- Candidate directions:
- Only consider repo-local config-loading alignment that does not force a broader Vite/Svelte/module-format migration.
- Defer if the path requires package-format or toolchain modernization.
- Expected benefit:
- Reduced ecosystem/tooling notice noise.
- Main risk:
- Expanding Track D into module-format/toolchain modernization work.

### 3. `carbon-icons-svelte` metadata warning removal

- Scope surfaces:
- `src/components/CommentDisplay.svelte`
- `src/components/low-level/PasswordInput.svelte`
- `package.json` only if another approved change already touches the dependency path
- Warning target:
- `[vite-plugin-svelte] WARNING: ... no exports condition for svelte`
- Risk class:
- `HIGH`
- Why it ranks third:
- The warning is driven by third-party package metadata rather than a repo-owned contract issue.
- The plan defaults this message to tolerated-residual scope unless the dependency is already changing for another approved reason.
- Attempting to remove it now likely means package churn or component import-path redesign with little direct build-output trust gain.
- Candidate directions:
- Keep as tolerance-first unless another approved change already touches icon dependencies.
- Expected benefit:
- Minor reduction in third-party warning noise.
- Main risk:
- Spending Track D scope on dependency churn with limited user-facing value.

## Selection Recommendation

Recommended first loop candidate: `stylesheet-path mitigation`.

Why:

- It is the only current frontend noise signature that is clearly repo-local and directly tied to build-output clarity.
- It offers the best chance of improving contributor trust without entering dependency/toolchain modernization work.
- If a safe mitigation does not emerge quickly, the fallback path is still in-plan: document the warning as an intentional residual notice and keep the output contract unchanged.

## Locked Loop Candidate

- Selected candidate:
- `stylesheet-path mitigation`
- Working hypothesis:
- Replace the hard-coded built stylesheet href in `src/entry/index.html` and `src/entry/icebreakers/index.html` with the source stylesheet entry so Vite can manage the build/dev asset rewrite directly, then simplify `vite.config.ts` only if the custom dev-only stylesheet HTML transform becomes unnecessary.
- Expected validation path:
- `yarn run build:frontend`
- `bash ./scripts/validate-frontend-artifacts.sh dist`
- `bash ./scripts/smoke-frontend-embed.sh dist`
- Revert trigger:
- Revert immediately if the change alters the emitted `dist/css/simple-comment-style.css` contract, breaks built HTML asset references, or leaves the warning unchanged while increasing config complexity.

## Loop 1 Outcome

- Result:
- `ACCEPT`
- Summary:
- The placeholder-based HTML transform removed the repo-local stylesheet-path warning while preserving the emitted `/css/simple-comment-style.css` contract in built HTML.
- Validation:
- `yarn run build:frontend`: passed
- `bash ./scripts/validate-frontend-artifacts.sh dist`: passed
- `bash ./scripts/smoke-frontend-embed.sh dist`: passed

## Continuation Decision

- Loop continuation:
- `stop after loop 1`
- Reason:
- The only repo-local frontend build warning/noise signature was removed.
- The remaining Vite CJS deprecation notice and `carbon-icons-svelte` warning are still tolerance-first under the approved Track D plan.
- No additional clearly low-risk repo-local candidate remains that would justify another remediation loop without expanding Track D toward broader toolchain or dependency churn.
45 changes: 45 additions & 0 deletions docs/archive/priority2-track-d/residual-notice-note.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Priority 2 Track D Residual Notice Note

## Residual Notices Accepted After Track D

### D001 — Vite CJS Node API deprecation notice

- Message:
- `The CJS build of Vite's Node API is deprecated.`
- Final Track D disposition:
- `tolerated residual notice`
- Why it remains:
- Track D removed the repo-local stylesheet-path warning first, as required by the plan.
- No additional clearly low-risk repo-local candidate was identified that would reduce this notice without pushing Track D into broader Vite/module-format modernization work.
- Owner:
- `frontend-build-system`
- Re-check trigger:
- revisit when a later approved Vite/toolchain modernization phase is opened, or if a clearly low-risk config-loading alignment becomes available on the current stack.
- Future handoff:
- carry this notice forward as modernization-phase input rather than re-opening Track D for speculative toolchain churn.

### D002 — `carbon-icons-svelte` export-condition warning

- Message:
- `[vite-plugin-svelte] WARNING: ... no exports condition for svelte`
- Final Track D disposition:
- `tolerated residual notice`
- Why it remains:
- The warning is driven by third-party package metadata rather than a repo-owned contract issue.
- Removing it during Track D would likely require dependency replacement or broader dependency churn with low direct value after the repo-local warning was already eliminated.
- Owner:
- `frontend-build-system`
- Re-check trigger:
- revisit if `carbon-icons-svelte` updates its metadata, if the dependency is replaced for another approved reason, or if a low-risk repo-local import/config alignment emerges.
- Future handoff:
- treat as dependency/watchlist input rather than active Track D remediation work.

## Track D Exit Statement

- Current frontend build noisy-signature state:
- `2` tolerated residual notices
- `0` actionable frontend warnings
- Exit basis:
- the only clearly repo-local frontend build warning/noise signature was removed,
- the remaining messages are intentionally documented with owner and re-check triggers,
- and additional remediation would exceed the approved low-risk Track D scope.
38 changes: 38 additions & 0 deletions docs/archive/priority2-track-d/validation-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Priority 2 Track D Validation Report

## Commands

- `yarn run build:frontend`
- `bash ./scripts/validate-frontend-artifacts.sh dist`
- `bash ./scripts/smoke-frontend-embed.sh dist`

## Results

- `yarn run build:frontend`
- Result: passed
- Observed frontend noisy message signatures after Track D:
- `The CJS build of Vite's Node API is deprecated.`
- `[vite-plugin-svelte] WARNING: ... no exports condition for svelte`
- Removed frontend noisy signature:
- `/css/simple-comment-style.css doesn't exist at build time, it will remain unchanged to be resolved at runtime`

- `bash ./scripts/validate-frontend-artifacts.sh dist`
- Result: passed
- Observed outcome:
- preserved `dist/css/simple-comment-style.css`
- preserved `dist/index.html`
- preserved `dist/icebreakers/index.html`
- preserved required JS/image/font outputs

- `bash ./scripts/smoke-frontend-embed.sh dist`
- Result: passed
- Observed outcome:
- built frontend still serves the baseline embed entry pages
- built bundles still expose `window.loadSimpleComment` and `window.getQuestion`
- built client bundle still contains baseline API-path references

## Summary

- Track D reduced the current frontend build noisy-signature count from `3` to `2`.
- Remaining frontend build messages are documented residual notices rather than current actionable warnings.
- The emitted `/css/simple-comment-style.css` contract remains intact after the accepted mitigation.
51 changes: 51 additions & 0 deletions docs/archive/priority2-track-d/warning-before-after.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# Priority 2 Track D Warning Before/After

Source logs:
- `docs/archive/priority2-track-d/build-frontend-baseline.log`
- `docs/archive/priority2-track-d/build-frontend-after.log`

## Before

Unique frontend noisy message signatures observed:

1. `The CJS build of Vite's Node API is deprecated.`
2. `[vite-plugin-svelte] WARNING: ... no exports condition for svelte`
3. `/css/simple-comment-style.css doesn't exist at build time, it will remain unchanged to be resolved at runtime`

Count: `3`

## After

Unique frontend noisy message signatures observed:

1. `The CJS build of Vite's Node API is deprecated.`
2. `[vite-plugin-svelte] WARNING: ... no exports condition for svelte`

Count: `2`

Removed signature:

- `/css/simple-comment-style.css doesn't exist at build time, it will remain unchanged to be resolved at runtime`

## Measured Delta

- Net change in noisy frontend message signatures: `-1`
- Repo-local stylesheet-path warning: removed
- Vite CJS deprecation notice: unchanged
- `carbon-icons-svelte` metadata warning: unchanged

## Validation Results

- `yarn run build:frontend`: passed
- `bash ./scripts/validate-frontend-artifacts.sh dist`: passed
- `bash ./scripts/smoke-frontend-embed.sh dist`: passed
- Built HTML contract check:
- `dist/index.html` and `dist/icebreakers/index.html` still point to `/css/simple-comment-style.css`

## Loop Decision

- Decision: `ACCEPT`
- Rationale:
- The selected stylesheet-path mitigation removed the only repo-local frontend build warning/noise signature.
- The build artifact contract and embed smoke checks remained green.
- The emitted HTML asset reference contract stayed aligned with the pre-Track D baseline.
19 changes: 19 additions & 0 deletions docs/archive/priority2-track-d/warning-register-current.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Priority 2 Track D Warning Register

Source log:
- `docs/archive/priority2-track-d/build-frontend-baseline.log`

## Current Frontend Build Messages

| ID | Tool / Stage | Message Signature | Source Surface | Frequency Pattern | Track D Disposition | Rationale | Owner | Re-check Trigger |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| D001 | Vite / frontend build setup | `The CJS build of Vite's Node API is deprecated.` | Vite Node API bootstrap via `vite.config.ts` on the current stack | Once per frontend build | `tolerated residual notice` | The message is ecosystem/tooling-facing and the current plan treats it as residual unless a clearly low-risk repo-local alignment fix exists without expanding modernization scope. | frontend-build-system | Re-check if Track D finds a low-risk repo-local fix, or when a later Vite/toolchain modernization phase is approved. |
| D002 | vite-plugin-svelte / frontend transform | `[vite-plugin-svelte] WARNING: ... no exports condition for svelte` | Third-party package metadata for `carbon-icons-svelte` imports used in `src/components/CommentDisplay.svelte` and `src/components/low-level/PasswordInput.svelte` | Once per frontend build | `tolerated residual notice` | The message is driven by third-party package metadata and Track D defaults to tolerance unless the dependency path is already changing for another approved reason. | frontend-build-system | Re-check if `carbon-icons-svelte` metadata changes upstream, if the dependency is replaced for another approved reason, or if a low-risk repo-local import/config alignment becomes available. |

Current post-Track D count: `2` residual notices, `0` actionable warnings.

## Resolved During Track D

| ID | Former Message Signature | Resolution | Evidence |
| --- | --- | --- | --- |
| D003 | `/css/simple-comment-style.css doesn't exist at build time, it will remain unchanged to be resolved at runtime` | Removed by replacing the literal stylesheet href in the entry HTML with a placeholder token and letting the Vite HTML transform inject the dev/build-specific stylesheet path while preserving the emitted `/css/simple-comment-style.css` contract. | `docs/archive/priority2-track-d/build-frontend-after.log`, `docs/archive/priority2-track-d/warning-before-after.md` |
4 changes: 2 additions & 2 deletions docs/norms/implementation.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ If there is no approved checklist created under `docs/norms/checklist.md` conven
## Start State

- Run relevant tests to understand baseline behavior.
- Check out a new branch named as `<verb>-<optionalAdj>-<noun>` to describe intent.
- This pattern is mandatory for new work branches.
- If the current branch is `master`, then check out a new branch
- named as `<verb>-<optionalAdj>-<noun>` to describe intent
- Use lowercase kebab-case tokens.
- Examples: `fix-auth-cookie`, `upgrade-core-dependencies`, `refactor-comment-pipeline`.
- Check `git status`.
Expand Down
Loading
Loading