Bring over RR cookies code into @remix-run/cookie package #10796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mjackson merged 18 commits into main from brophdawg11/cookies

Nov 4, 2025

Contributor

brophdawg11 commented Oct 22, 2025 •

edited

Loading

Adds a new @remix-run/cookie package - brought over from https://github.com/remix-run/react-router/blob/main/packages/react-router/lib/server-runtime/cookies.ts

brophdawg11 mentioned this pull request

Add cookie package #10789

Closed

brophdawg11 changed the title ~~Bring over RR cookies code into @remix-run/cookies package~~ Bring over RR cookies code into @remix-run/cookie package

brophdawg11 commented

View reviewed changes

packages/cookie/src/lib/cookie.test.ts Show resolved Hide resolved

brophdawg11 commented

View reviewed changes

packages/cookie/src/index.ts Outdated Show resolved Hide resolved

brophdawg11 commented

View reviewed changes

packages/cookie/package.json Show resolved Hide resolved

brophdawg11 commented

View reviewed changes

packages/cookie/LICENSE Show resolved Hide resolved

brophdawg11 commented

View reviewed changes

packages/cookie/package.json Outdated Show resolved Hide resolved

brophdawg11 mentioned this pull request

Bring over RR session code into @remix-run/session package #10797

Closed

mjackson requested changes

View reviewed changes

Member

mjackson left a comment

Thanks for the PR!

packages/cookie/CHANGELOG.md Outdated Show resolved Hide resolved

packages/cookie/LICENSE Show resolved Hide resolved

packages/cookie/package.json Show resolved Hide resolved

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/crypto.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/crypto.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/crypto.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/crypto.ts Outdated Show resolved Hide resolved

packages/cookie/package.json Outdated Show resolved Hide resolved

MichaelDeBoey linked an issue

that may be closed by this pull request

Add cookie package #10789

Closed

brophdawg11 requested a review from mjackson

October 23, 2025 14:11

MichaelDeBoey requested changes

View reviewed changes

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/README.md Outdated Show resolved Hide resolved

packages/cookie/README.md Outdated Show resolved Hide resolved

Contributor Author

brophdawg11 commented Oct 29, 2025

@mjackson I updated this with the same thing we did in the session PR:

interface Cookie + function createCookie are now collapsed into class Cookie
isCookie removed in favor of instanceof Cookie

brophdawg11 force-pushed the brophdawg11/cookies branch from cbe4632 to 8652d7b Compare

October 31, 2025 16:29

mjackson requested changes

View reviewed changes

Member

mjackson left a comment

Let's remove JSON encoding/decoding and force people to use string values.

packages/cookie/src/lib/cookie.ts Outdated Show resolved Hide resolved

packages/cookie/README.md Outdated Show resolved Hide resolved

brophdawg11 added 14 commits

November 3, 2025 12:06


          Bring over RR cookies code into @remix-run/cookies package

d78f9c5


          Update build and exports

7ec1d0f


          Rename @remix-run/cookies -> @remix-run/cookie

84ee613


          Reorder package.json

a34c1da


          Add README

c076ab6


          Updates

21ac5f8


          Remove stale links

8a930b9


          bundle cookie dep and move to a devDependency

e0e33c5


          PR feedback

62a2355


          Refactor createCookie() -> new Cookie()

9d7d434


          Convert any's to unknown's

9f0f508


          Remove stale code block from README

b76dfdd


          Remove API docs from README

6f1d7fb


          Remove JSON encoding from cookies

b8db250

brophdawg11 force-pushed the brophdawg11/cookies branch from 93e76b3 to b8db250 Compare

November 3, 2025 17:07


          cookie changes

852e17d

brophdawg11 mentioned this pull request

Bring over RR session code into @remix-run/session package #10811

Closed

brophdawg11 commented

View reviewed changes

packages/cookie/src/index.ts Outdated Show resolved Hide resolved

brophdawg11 commented

View reviewed changes

packages/cookie/package.json Outdated Show resolved Hide resolved

mjackson and others added 3 commits

November 4, 2025 11:35


          Add Partitioned support to Set-Cookie header

0b3b7d9


          Finish cookie package


          Merge branch 'main' into brophdawg11/cookies

0c3c155

mjackson merged commit 8be6b0f into main

4 checks passed

mjackson deleted the brophdawg11/cookies branch

November 4, 2025 19:58

MichaelDeBoey added feat:cookies pkg:cookie labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat:cookies pkg:cookie