Skip to content

fix(tutorial): use "root" as root div id #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timdorr merged 2 commits into from
Jan 16, 2022
Merged

fix(tutorial): use "root" as root div id #8582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45eda1
fix(tutorial): use "root" as root div id
ChristopherChudzicki Jan 14, 2022
7445d69
sign cla
ChristopherChudzicki Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- brockross
- chaance
- chasinhues
- christopherchudzicki
- elylucas
- hongji00
- JakubDrozd
Expand Down
2 changes: 1 addition & 1 deletion tutorial/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<title>React Router - Tutorial</title>
</head>
<body>
<div id="app"><!--app-html--></div>
<div id="root"><!--app-html--></div>
<script type="module" src="/src/main.jsx"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion tutorial/src/main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ import * as ReactDOM from "react-dom";
import App from "./App";
import "./main.css";

let rootElement = document.getElementById("app");
let rootElement = document.getElementById("root");
ReactDOM.render(<App />, rootElement);