Skip to content

Fix minor typos in the "Matching generally static values" FAQ example#8548

Merged
timdorr merged 2 commits intoremix-run:mainfrom
jmargeta:patch-1
Dec 31, 2021
Merged

Fix minor typos in the "Matching generally static values" FAQ example#8548
timdorr merged 2 commits intoremix-run:mainfrom
jmargeta:patch-1

Conversation

@jmargeta
Copy link
Contributor

This fixes the example by using <Lang lang="…"/> instead of <Lang code="…"/> (to respect Lang's signature) and by setting the language codes to correspond with the paths.

This fixes the "Matching generally static values" example.
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 30, 2021

Hi @jmargeta,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 30, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Dec 31, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants