This repository was archived by the owner on Mar 3, 2021. It is now read-only.
remove unneded if-elses; refactor; convert callbacks to promises #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unneded if-elses replace this.codeResolver.resolveCode callback with a promise remove unneded if-elses convert TraceRetriever.getTrace to a promise move getTrace to trace manager and remove traceRetriever file remove unneded callback parameter remove unneded callback from traceManager methods
Contributor
Author
|
closed in favour of remix-project-org/remix-project#60 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unneded if-elses
replace this.codeResolver.resolveCode callback with a promise
remove unneded if-elses
convert TraceRetriever.getTrace to a promise
move getTrace to trace manager and remove traceRetriever file
remove unneded callback parameter
remove unneded callback from traceManager methods