Fix removePrefix from fileProvider #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
fixFileManagerAPI
branch
3 times, most recently
from
8003c7d to
c125f2e
Compare
yann300
force-pushed
the
fixFileManagerAPI
branch
from
c125f2e to
630a5bb
Compare
yann300
force-pushed
the
fixFileManagerAPI
branch
from
359f482 to
6e3ce76
Compare
GrandSchtroumpf
approved these changes
Jan 4, 2021
Contributor
GrandSchtroumpf
left a comment
GrandSchtroumpf
left a comment
There was a problem hiding this comment.
Looks like a lot of check for "/" at different places. I fear to might be difficult to follow if an issue occurs. I would advocate for putting all the formatting in one reusable function outside of the class if possible. But I don't have the big picture here, so I'm not sure it's possible...
This was referenced Feb 2, 2024
This was referenced Feb 3, 2024
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.