Refactor Learn eth plugin #6328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hsy822
commented
Sep 2, 2025
hsy822
commented
- Added filtering and search functionality
- Refactored the UI for improved usability and structure
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…m/remix-project into refactor/learneth-plugin
Aniket-Engg
reviewed
Sep 5, 2025
Collaborator
There was a problem hiding this comment.
- There should not be two tags for Remix: Remix & Remix-IDE
- In case no tutorial matches the filter selection, it should show
No match foundorNo tutorials foundSimilar for search bar.
- ^^ this icon is misaligned
- There are errors in browser console:
Invalid DOM propertyfill-rule. Did you meanfillRule?&Invalid DOM propertyclip-rule. Did you meanclipRule?
- These button should have some colours. As of now they show colour on hover only
joeizang
previously requested changes
Sep 5, 2025
Collaborator
joeizang
left a comment
joeizang
left a comment
There was a problem hiding this comment.
-
The LearnEth Plugin should be expanded when it opens up. It's content at the plugin's regular width cuts off its content.
-
I am not sure about the scroll on the X axis.
The Contrast here can be improved.
The padding on the left and right of the button isn't right.
Collaborator
Author
|
@Aniket-Engg @joeizang I have resolved all the issues mentioned. Please check and let me know. Thank you. |
Aniket-Engg
reviewed
Sep 8, 2025
Aniket-Engg
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.