Skip to content

Show network name and ticker #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yann300 merged 4 commits into from
Jul 9, 2025
Merged

Show network name and ticker #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6c2ee5
get network name
Aniket-Engg Jul 7, 2025
0d1fdc4
show symbol
Aniket-Engg Jul 8, 2025
65141e2
save in localstorage
Aniket-Engg Jul 9, 2025
9092db4
update default currency
Aniket-Engg Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/remix-ide/src/blockchain/blockchain.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const profile = {
name: 'blockchain',
displayName: 'Blockchain',
description: 'Blockchain - Logic',
methods: ['dumpState', 'getCode', 'getTransactionReceipt', 'addProvider', 'removeProvider', 'getCurrentFork', 'isSmartAccount', 'getAccounts', 'web3VM', 'web3', 'getProvider', 'getCurrentProvider', 'getCurrentNetworkStatus', 'getAllProviders', 'getPinnedProviders', 'changeExecutionContext', 'getProviderObject'],
methods: ['dumpState', 'getCode', 'getTransactionReceipt', 'addProvider', 'removeProvider', 'getCurrentFork', 'isSmartAccount', 'getAccounts', 'web3VM', 'web3', 'getProvider', 'getCurrentProvider', 'getCurrentNetworkStatus', 'getCurrentNetworkCurrency', 'getAllProviders', 'getPinnedProviders', 'changeExecutionContext', 'getProviderObject'],

version: packageJson.version
}
Expand Down Expand Up @@ -63,6 +63,11 @@ export class Blockchain extends Plugin {
}
error?: string
}
networkNativeCurrency: {
name: string,
symbol: string,
decimals: number
}
providers: {[key: string]: VMProvider | InjectedProvider | NodeProvider }
transactionContextAPI: TransactionContextAPI
registeredPluginEvents: string[]
Expand Down Expand Up @@ -100,6 +105,7 @@ export class Blockchain extends Plugin {
// the first item in the list should be latest fork.
this.defaultPinnedProviders = ['vm-prague', 'vm-cancun', 'vm-mainnet-fork', 'walletconnect', 'injected-MetaMask', 'basic-http-provider', 'hardhat-provider', 'foundry-provider', 'desktopHost']
this.networkStatus = { network: { name: this.defaultPinnedProviders[0], id: ' - ' } }
this.networkNativeCurrency = { name: "Ether", symbol: "ETH", decimals: 18 }
this.pinnedProviders = []
this.setupEvents()
this.setupProviders()
Expand All @@ -120,6 +126,7 @@ export class Blockchain extends Plugin {
if (plugin.name === this.executionContext.executionContext) {
this.detectNetwork((error, network) => {
this.networkStatus = { network, error }
if (network.networkNativeCurrency) this.networkNativeCurrency = network.networkNativeCurrency
this._triggerEvent('networkStatus', [this.networkStatus])
})
}
Expand Down Expand Up @@ -184,6 +191,7 @@ export class Blockchain extends Plugin {
this._triggerEvent('contextChanged', [context])
this.detectNetwork((error, network) => {
this.networkStatus = { network, error }
if (network.networkNativeCurrency) this.networkNativeCurrency = network.networkNativeCurrency
this._triggerEvent('networkStatus', [this.networkStatus])
})
})
Expand All @@ -199,6 +207,7 @@ export class Blockchain extends Plugin {
setInterval(() => {
this.detectNetwork((error, network) => {
this.networkStatus = { network, error }
if (network.networkNativeCurrency) this.networkNativeCurrency = network.networkNativeCurrency
this._triggerEvent('networkStatus', [this.networkStatus])
})
}, 30000)
Expand All @@ -208,6 +217,10 @@ export class Blockchain extends Plugin {
return this.networkStatus
}

getCurrentNetworkCurrency() {
return this.networkNativeCurrency
}

isSmartAccount(address) {
return this.transactionContextAPI.isSmartAccount(address)
}
Expand Down
47 changes: 32 additions & 15 deletions apps/remix-ide/src/blockchain/execution-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,34 +78,51 @@ export class ExecutionContext {
callback && callback('No provider set')
return reject('No provider set')
}
const cb = (err, id) => {
let name = null
const cb = async (err, id) => {
let name = 'Custom'
let networkNativeCurrency = { name: "Ether", symbol: "ETH", decimals: 18 }
if (err) name = 'Unknown'
// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md
else if (id === 1) name = 'Main'
else if (id === 3) name = 'Ropsten'
else if (id === 4) name = 'Rinkeby'
else if (id === 5) name = 'Goerli'
else if (id === 42) name = 'Kovan'
else if (id === 11155111) name = 'Sepolia'
else name = 'Custom'

else {
let networkDetails = localStorage.getItem('networkDetails')
if (!networkDetails) networkDetails = '{}'
networkDetails = JSON.parse(networkDetails)
if (networkDetails[id]) {
name = networkDetails[id].name
networkNativeCurrency = networkDetails[id].nativeCurrency
} else {
const response = await fetch('https://chainid.network/chains.json')
if (response.ok) {
Copy link
Contributor

@yann300 yann300 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the case where the nativeCurrency can't be resolved is handled? like defaulting to eth or something?

Copy link
Collaborator Author

@Aniket-Engg Aniket-Engg Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is done here: https://github.com/ethereum/remix-project/pull/6141/files#diff-edc29c7646590f31b7818ef955996b84c9d1b0ca9c874b03b070244bee9cc8cbR108

Copy link
Collaborator Author

@Aniket-Engg Aniket-Engg Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want, I can do the same in this file too

Copy link
Contributor

@yann300 yann300 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am saying that because line 83 the local variable is set to null.

Copy link
Collaborator Author

@Aniket-Engg Aniket-Engg Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will update that here too

Copy link
Collaborator Author

@Aniket-Engg Aniket-Engg Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

const networks = await response.json()
const connectedNetwork = networks.find((n) => n.chainId === id)
if (connectedNetwork) {
name = connectedNetwork.name
networkNativeCurrency = connectedNetwork.nativeCurrency
networkDetails[id] = { name, nativeCurrency: networkNativeCurrency}
localStorage.setItem('networkDetails', JSON.stringify(networkDetails))
}
}
}
}

if (id === 1) {
web3.eth.getBlock(0).then((block) => {
if (block && block.hash !== this.mainNetGenesisHash) name = 'Custom'
callback && callback(err, { id, name, lastBlock: this.lastBlock, currentFork: this.currentFork })
return resolve({ id, name, lastBlock: this.lastBlock, currentFork: this.currentFork })
callback && callback(err, { id, name, lastBlock: this.lastBlock, currentFork: this.currentFork, networkNativeCurrency })
return resolve({ id, name, lastBlock: this.lastBlock, currentFork: this.currentFork, networkNativeCurrency })
}).catch((error) => {
// Rabby wallet throws an error at this point. We are in that case unable to check the genesis hash.
callback && callback(err, { id, name, lastBlock: this.lastBlock, currentFork: this.currentFork })
return resolve({ id, name, lastBlock: this.lastBlock, currentFork: this.currentFork })
callback && callback(err, { id, name, lastBlock: this.lastBlock, currentFork: this.currentFork, networkNativeCurrency })
return resolve({ id, name, lastBlock: this.lastBlock, currentFork: this.currentFork, networkNativeCurrency })
})
} else {
callback && callback(err, { id, name, lastBlock: this.lastBlock, currentFork: this.currentFork })
return resolve({ id, name, lastBlock: this.lastBlock, currentFork: this.currentFork })
callback && callback(err, { id, name, lastBlock: this.lastBlock, currentFork: this.currentFork, networkNativeCurrency })
return resolve({ id, name, lastBlock: this.lastBlock, currentFork: this.currentFork, networkNativeCurrency })
}
}
web3.eth.net.getId().then(id=>cb(null,parseInt(id))).catch(err=>cb(err))
web3.eth.net.getId().then(async (id) => await cb(null, parseInt(id))).catch(err => cb(err))
}
})
}
Expand Down
4 changes: 2 additions & 2 deletions libs/remix-ui/helper/src/lib/remix-ui-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ export const isNumeric = (value) => {
return /^\+?(0|[1-9]\d*)$/.test(value)
}

export const shortenAddress = (address, etherBalance?) => {
export const shortenAddress = (address, etherBalance?, currency = 'ETH') => {
const len = address.length

return address.slice(0, 5) + '...' + address.slice(len - 5, len) + (etherBalance ? ' (' + etherBalance.toString() + ' ether)' : '')
return address.slice(0, 5) + '...' + address.slice(len - 5, len) + (etherBalance ? ' (' + etherBalance.toString() + ' ' + currency + ')' : '')
}

export const addressToString = (address) => {
Expand Down
5 changes: 4 additions & 1 deletion libs/remix-ui/run-tab/src/lib/actions/account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ export const fillAccountsList = async (plugin: RunTab, dispatch: React.Dispatch<

for (const account of accounts) {
const balance = await plugin.blockchain.getBalanceInEther(account)
loadedAccounts[account] = shortenAddress(account, balance)
if (provider.startsWith('injected') && plugin.blockchain && plugin.blockchain['networkNativeCurrency'] && plugin.blockchain['networkNativeCurrency'].symbol)
loadedAccounts[account] = shortenAddress(account, balance, plugin.blockchain['networkNativeCurrency'].symbol)
else
loadedAccounts[account] = shortenAddress(account, balance)
if (safeAddresses.length && safeAddresses.includes(account)) loadedAccounts[account] = `[SMART] ${loadedAccounts[account]}`
}
dispatch(fetchAccountsListSuccess(loadedAccounts))
Expand Down
1 change: 0 additions & 1 deletion libs/remix-ui/run-tab/src/lib/actions/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export const setupEvents = (plugin: RunTab) => {
if (error) {
const netUI = 'can\'t detect network'
setNetworkNameFromProvider(dispatch, netUI)

return
}
const networkProvider = plugin.networkModule.getNetworkProvider.bind(plugin.networkModule)
Expand Down