Skip to content

Fixed tab title hidden display #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioedeveloper merged 1 commit into from
Nov 3, 2020
Merged

Fixed tab title hidden display #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions apps/remix-ide/src/app/panels/tab-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@ var yo = require('yo-yo')
var $ = require('jquery')
const EventEmitter = require('events')
const globalRegistry = require('../../global/registry')
const csjs = require('csjs-inject')

require('remix-tabs')

const css = csjs`
.remix_tabs div[title]{
display: flex;
}
`

export class TabProxy {
constructor (fileManager, editor, appManager) {
this.event = new EventEmitter()
Expand Down Expand Up @@ -140,11 +147,10 @@ export class TabProxy {
const tabPath = slash.reverse()
const tempTitle = []

for(let i = 0; i < tabPath.length; i++) {
tempTitle.push(tabPath[i])
const formatPath = [...tempTitle].reverse()

if(!title) {
if(!title) {
for(let i = 0; i < tabPath.length; i++) {
tempTitle.push(tabPath[i])
const formatPath = [...tempTitle].reverse()
const index = this.loadedTabs.findIndex(({ title }) => title === formatPath.join('/'))

if (index === -1) {
Expand Down Expand Up @@ -175,12 +181,12 @@ export class TabProxy {
}
break;
}
} else {
this.loadedTabs.push({
name,
title
})
}
} else {
this.loadedTabs.push({
name,
title
})
}

this._view.filetabs.addTab({
Expand Down Expand Up @@ -213,7 +219,7 @@ export class TabProxy {
}

renderTabsbar () {
this._view.filetabs = yo`<remix-tabs></remix-tabs>`
this._view.filetabs = yo`<remix-tabs class=${css.remix_tabs}></remix-tabs>`
this._view.filetabs.addEventListener('tabClosed', (event) => {
if (this._handlers[event.detail]) this._handlers[event.detail].close()
this.event.emit('tabCountChanged', this._view.filetabs.tabs.length)
Expand Down