Add Sol2Uml To Remix #3245
Merged
Add Sol2Uml To Remix #3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joeizang
force-pushed
the
add-sol2Uml
branch
from
a74e8b1 to
e9b2113
Compare
joeizang
force-pushed
the
add-sol2Uml
branch
from
9be2685 to
33d9907
Compare
joeizang
force-pushed
the
add-sol2Uml
branch
from
33c0d7d to
0c2b41e
Compare
Closed
joeizang
force-pushed
the
add-sol2Uml
branch
2 times, most recently
from
c3de8ac to
db1ec65
Compare
Contributor
|
the flatten action doesn't do anything. |
yann300
reviewed
Jan 2, 2023
yann300
reviewed
Jan 2, 2023
Aniket-Engg
force-pushed
the
add-sol2Uml
branch
from
0526995 to
5198d3d
Compare
Aniket-Engg
reviewed
Jan 12, 2023
| resolveContentAndSave: (url: string) => Promise<string> | ||
| fileExists: (file: string) => Promise<boolean> | ||
| writeFile: (file: string, content: string) => Promise<void> | ||
| writeFile: (file: string, content: any) => Promise<void> |
Collaborator
There was a problem hiding this comment.
is this change necessary?
Collaborator
Author
There was a problem hiding this comment.
Yes, when left as a string, It becomes difficult to write the pdf to file explorer. Even though deep in the recesses of the plugin engin, it takes a string. Making it any allows me to write the result from generating the pdf to fileexplorer.
joeizang
force-pushed
the
add-sol2Uml
branch
2 times, most recently
from
f0c45a1 to
68cc318
Compare
joeizang
force-pushed
the
add-sol2Uml
branch
2 times, most recently
from
4790c76 to
6b23eb4
Compare
Aniket-Engg
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #3238