subsequent calls when accesssing assosiation objects

[revathskumar]

I have a Store model and Inventory model in which Store has_many Inventories.

The her document says

Subsequent calls to #comments, #role and #organization will not trigger extra HTTP requests and will return the cached objects.

But when I tied, Her is making subsequent calls.

@store = Store.find(1)
@products = @store.inventories # Fires first call to inventories which is ok.
@metadata = @products.metadata # Fires another request to inventories which is unexpected

@products. each do | product | # Again fires another request to inventories
    # do something with product
end

Any one facing the same issue?

I tried with master branch and v0.6.8 same issue on both.

[reejosamuel]

@revathskumar

Have enabled cache on the request as mentioned in the documentation

Caching

Again, using the faraday_middleware and memcached gems makes it very easy to cache requests and responses.

In your Gemfile:

gem "her"
gem "faraday_middleware"
gem "memcached"

In your Ruby code:

Her::API.setup url: "https://api.example.com" do |c|
  # Request
  c.use FaradayMiddleware::Caching, Memcached::Rails.new('127.0.0.1:11211')

  # Response
  c.use Her::Middleware::DefaultParseJSON

  # Adapter
  c.use Faraday::Adapter::NetHttp
end

class User
  include Her::Model
end

@user = User.find(1)
# GET "/users/1"

@user = User.find(1)
# This request will be fetched from memcached

[revathskumar]

@reejosamuel Thanks. I thought they will cache it on the object if Memcache is not configured.

[pencil]

@remiprev I think this might be a bug indeed. AFAIK at one point her cached associated objects in memory. Was this changed on purpose?

[remi]

@pencil You’re right, these lines (1, 2) are causing the problem. We need to cache the results in the object without using @parent.attributes.

[pencil]

@remiprev What approach would you suggest to fix this? Could we just cache the data on the instance itself?