Remove support for Node.js 12 in CLI #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for the update of unified-args.
github-actions
bot
added
🤞 phase/open
Member
|
Can we do it for the CLI (and CI) only, so as not to require a major for remark/remark-parse/remark-stringify? |
Member
Author
|
As in, revert the changes in the other readmes? |
Member
|
Yup! |
Node.js 12 support is only dropped for `remark-cli`.
This comment was marked as resolved.
This comment was marked as resolved.
ChristianMurphy
approved these changes
Jun 23, 2022
wooorm
approved these changes
Jun 24, 2022
wooorm
changed the title
This comment has been minimized.
This comment has been minimized.
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jun 26, 2022
…ishearth update node.js version in `remark.yml` Optional chain (`?.`) is available in `node v14`, but node version in CI is `node v12`, so CI is failed now. ref: https://github.com/rust-lang/rust-clippy/runs/7059529735?check_suite_focus=true optional chain: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#browser_compatibility Corresponding PR (maybe) remarkjs/remark#1007 changelog: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This is a preparation for the update of
unified-argsinremark-cli. This also means none of the other packages in the mono repo are tested against Node 12 anymore.