fix: apply middleware before internal middleware; add CORS support #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Build blocked on vitejs/vite#17836 |
reifiedbeans
force-pushed
the
cors-fallback-fix
branch
from
21f8615 to
7af2c76
Compare
Owner
Author
|
Audited the other server middlewares used in Vite currently and determined that there shouldn't be any middleware other than CORS that this plugin should need to implement. |
Owner
Author
|
Using the following code as a test sample, this change passes manual testing for resolution and CORS. vite.config.ts import { defineConfig } from "vite";
import serveStatic from "vite-plugin-serve-static";
export default defineConfig({
plugins: [
serveStatic([
{
pattern: /^\/test/,
resolve: './test.json',
},
]),
],
});fetch.html <!doctype html>
<html lang="en">
<script>
async function getTest() {
const res = await fetch('http://localhost:5173/test');
console.log(res);
}
void getTest();
</script>
</html> |
|
🎉 This issue has been resolved in version 1.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6