Fixed incorrect default iMaxClip value for grenades#1109
Merged
s1lentq merged 1 commit intorehlds:masterfrom Sep 26, 2025
Merged
Fixed incorrect default iMaxClip value for grenades#1109s1lentq merged 1 commit intorehlds:masterfrom
s1lentq merged 1 commit intorehlds:masterfrom
Conversation
This also fixes the values for knife and C4, only in the WeaponInfo structure, which has no repercussions.
|
@s1lentq please add to master all requests |
s1lentq
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The default maximum values for the grenade
MaxClipwere incorrectly assigned inGetItemInfo. This was a simple, harmless typo. This also fixes the values for knife and C4, only in theWeaponInfostructure, which has no repercussions.Approach
Modify
gunClipSizevalues fromg_weaponInfo_defaultarray on NoClip weapons.Learning
The first appearance of these incorrect values dates back to 2016 in the commit 183a9f6
Specific lines:
ReGameDLL_CS/regamedll/dlls/wpn_shared/wpn_flashbang.cpp
Line 44 in 24744cd
ReGameDLL_CS/regamedll/dlls/wpn_shared/wpn_hegrenade.cpp
Line 47 in 24744cd
ReGameDLL_CS/regamedll/dlls/wpn_shared/wpn_smokegrenade.cpp
Line 45 in 24744cd