Skip to content

[bugfix] Do not hard code the value type of a RegressionTestDict - #3660

Merged
vkarak merged 2 commits into
reframe-hpc:developfrom
vkarak:bugfix/regressiontestdict-values
Apr 30, 2026
Merged

[bugfix] Do not hard code the value type of a RegressionTestDict#3660
vkarak merged 2 commits into
reframe-hpc:developfrom
vkarak:bugfix/regressiontestdict-values

Conversation

@vkarak

@vkarak vkarak commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Closes #3659.

@vkarak vkarak added this to the ReFrame 4.10 milestone Apr 27, 2026
@vkarak vkarak self-assigned this Apr 27, 2026
@codecov

codecov Bot commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.88%. Comparing base (fcbd6df) to head (e45d43d).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3660   +/-   ##
========================================
  Coverage    91.87%   91.88%           
========================================
  Files           62       62           
  Lines        13756    13758    +2     
========================================
+ Hits         12638    12641    +3     
+ Misses        1118     1117    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

victorusu
victorusu approved these changes Apr 28, 2026
View reviewed changes

@victorusu victorusu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in ReFrame Backlog Apr 28, 2026
@vkarak
vkarak force-pushed the bugfix/regressiontestdict-values branch from 4cecef9 to 5faff61 Compare April 29, 2026 08:00
@vkarak
vkarak marked this pull request as draft April 29, 2026 11:55
@vkarak

vkarak commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Converting to draft as I'm getting another error, which I need to reproduce and investigate.

@vkarak
vkarak marked this pull request as ready for review April 29, 2026 21:59
@vkarak

vkarak commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Converting to draft as I'm getting another error, which I need to reproduce and investigate.

It was a very weird error this one: storing the value type inside the _RegressionTestDict was preventing the test from being copied for generating its test cases during loading. This was also the reason that the unit tests didn't catch it, since we created the tests inside the unit tests, outside the normal loading process.

I've added a unit test to reproduce the problem and fixed the error.

vkarak and others added 2 commits April 30, 2026 00:01
@vkarak
Do not hard code the value type of a RegressionTestDict
9e4a4a1 
Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
@vkarak
Do not store the value type in the _RegressionTestDict
e45d43d 
Storing the value type prevents the test from being copied when creating
the test case combinations.

Added unit test to reproduce the problem.

Signed-off-by: Vasileios Karakasis <vkarakasis@nvidia.com>
@vkarak
vkarak force-pushed the bugfix/regressiontestdict-values branch from 8ac3ab4 to e45d43d Compare April 29, 2026 22:01
@vkarak
vkarak merged commit fe5f765 into reframe-hpc:develop Apr 30, 2026
34 of 36 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in ReFrame Backlog Apr 30, 2026
@vkarak
vkarak deleted the bugfix/regressiontestdict-values branch April 30, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorusu victorusu victorusu approved these changes
@gppezzi gppezzi Awaiting requested review from gppezzi
@jack-morrison jack-morrison Awaiting requested review from jack-morrison

Assignees

@vkarak vkarak

Labels

bugfix prio: important test syntax

Projects

ReFrame Backlog
Status: Done

Milestone

ReFrame 4.10

Development

Successfully merging this pull request may close these issues.

RegressionTestDict type requires values to be a reference tuple

2 participants

@vkarak @victorusu