Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "redux",
"version": "4.0.4",
"version": "4.0.5",
"description": "Predictable state container for JavaScript apps",
"license": "MIT",
"homepage": "http://redux.js.org",
Expand Down
37 changes: 33 additions & 4 deletions src/createStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ export default function createStore<
let currentListeners: (() => void)[] | null = []
let nextListeners = currentListeners
let isDispatching = false
var isNotifyListenersNextFrame = false
var alreadyNotifingListenersOnNextFrame = false

/**
* This makes a shallow copy of currentListeners so we can use
Expand Down Expand Up @@ -197,6 +199,18 @@ export default function createStore<
}
}

/**
*
* @param {boolean} shouldNotifyOnNextFrame A boolean to configure the store
* to notify the listeners only on the next frame or after every dispatch.
* The state still keep changing between dispatches, only listeners (subscribers to store) don't run.
* Set to true if listeners should be notified only once per frame.
* Set to false (default) if listeners should be notified after every dispatch
*/
function setNotifyListenersOnNextFrame(shouldNotifyOnNextFrame) {
isNotifyListenersNextFrame = shouldNotifyOnNextFrame
}

/**
* Dispatches an action. It is the only way to trigger a state change.
*
Expand Down Expand Up @@ -248,10 +262,24 @@ export default function createStore<
isDispatching = false
}

const listeners = (currentListeners = nextListeners)
for (let i = 0; i < listeners.length; i++) {
const listener = listeners[i]
listener()
function notifyListeners() {
const listeners = (currentListeners = nextListeners)
for (let i = 0; i < listeners.length; i++) {
const listener = listeners[i]
listener()
}
}

if (isNotifyListenersNextFrame) {
if (!alreadyNotifingListenersOnNextFrame) {
alreadyNotifingListenersOnNextFrame = true
window.requestAnimationFrame(() => {
notifyListeners()
alreadyNotifingListenersOnNextFrame = false
})
}
} else {
notifyListeners()
}

return action
Expand Down Expand Up @@ -345,6 +373,7 @@ export default function createStore<
subscribe,
getState,
replaceReducer,
setNotifyListenersOnNextFrame,
[$$observable]: observable
} as unknown) as Store<ExtendState<S, StateExt>, A, StateExt, Ext> & Ext
return store
Expand Down