Skip to content

feat(compose): optimize one function case #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 3 commits into from
May 8, 2016
Merged

feat(compose): optimize one function case #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c088fe
feat(compose): optimize one function case
julien-f May 7, 2016
dc1d766
style(compose): do not use a variable for funcs.length
julien-f May 8, 2016
5f55d8f
test(compose): add test for a single param
julien-f May 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/compose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@
export default function compose(...funcs) {
if (funcs.length === 0) {
Copy link

@dsomel21 dsomel21 Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I be using triple = ?

Copy link
Contributor

@TrySound TrySound Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It's strict equality.

return arg => arg
} else {
const last = funcs[funcs.length - 1]
const rest = funcs.slice(0, -1)
return (...args) => rest.reduceRight((composed, f) => f(composed), last(...args))
}

if (funcs.length === 1) {
return funcs[0]
}

const last = funcs[funcs.length - 1]
const rest = funcs.slice(0, -1)
return (...args) => rest.reduceRight((composed, f) => f(composed), last(...args))
}
6 changes: 6 additions & 0 deletions test/compose.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,11 @@ describe('Utils', () => {
expect(compose()(3)).toBe(3)
expect(compose()()).toBe(undefined)
})

it('returns the first function if given only one', () => {
const fn = () => {}

expect(compose(fn)).toBe(fn)
})
})
})