Skip to content

Conversation

@kili-ilo
Copy link

Update main script path in package.json to reference src/, not lib/.

Update `main` script path in `package.json` to reference `src/`, not `lib/`.
@TrySound
Copy link
Contributor

@jvanbrug src is es2015 code which doesn't work in all environments. lib contains code processed with babel, es contains processed code but with es2015-modules. Your PR doesn't make sense.

@mxstbr
Copy link
Contributor

mxstbr commented Apr 30, 2016

The current behaviour is correct, as @TrySound mentioned, we want to give users access to the processed code, not the source! If users don't have an ES* transpiler and we only give them access to the source, they aren't able to use it, which we want to avoid.

Thanks for taking the time to submit this PR, we appreciate it a lot!

@mxstbr mxstbr closed this Apr 30, 2016
@kili-ilo
Copy link
Author

kili-ilo commented May 1, 2016

Noob PR, thanks for the insight!

@gaearon
Copy link
Contributor

gaearon commented May 1, 2016

No problem. Thanks for taking the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants