Fix test code coverage reporting#850
Merged
Merged
Conversation
Member
|
Sorry, I forgot to look at this! Thanks! |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #828 by updating the nyc configuration.
This builds on the work of @IlyaRucavitcyn's fork. Turns out the issue was the
npm testcommand is setting theBABEL_ENVenvironment variable tocommonjs, which doesn't have the required istanbul plugin.To fix this, I just added the commonjs env plugin to the babel test environment and then switched
npm testto useBABEL_ENV=test.It now seems to produce an accurate coverage report and
coverage.lcovis no longer empty after runningnpm run coverage.