(feat): support react 16.6#1062
Conversation
|
Wanted to include a react 16.6 test but i see that does not work :/ |
|
#914 is related here. I'll check this out locally in a bit and see what's up. I believe what you've got is correct FWIW. |
It works when i test it locally, but yes i'd like to run that test only in React 16.6 which as far as i see is not possible with current config. The test I added is the one failing and is skipped for now. |
|
We just added 16.5 in #1043, so it should follow those conventions. And again, everything looks like it should be right here. I'll see what I can do about getting it added to the suite cleanly. As for that failing test, you can wrap it in |
|
Will add the if when I get home :) Thanks for reviewing already, anything else needs changing? |
|
Took care of that on the web for you. Looks like the only thing is you used an outdated version of npm, but I'll fix that up after the fact when I get to my laptop. |
|
Oh, thanks for telling me. I mostly use Yarn and Yarn Pnp atm so didn't bring that in mind |
|
Thanks for putting this together! |
* chore: upgrade dependencies * chore: support react-is in rollup * tests: adjust test react version * test: provide tests for react 16.6 * feat: implement the support for react 16.6 * fix: remove jsx variant * chore: fix failing test by skipping it until further notice * fix: skip failing test * Add 16.6 to the test matrix * Wrap the test in a check for React.memo
2 participants
Tests are provided aswell, i hope i did this the right way :)