Add command logging and update serialport library#1
Open
Conversation
nylen
force-pushed
the
update/node-serialport
branch
from
d597e11 to
7a2a1c8
Compare
nylen
force-pushed
the
update/node-serialport
branch
from
7a2a1c8 to
0bfa54f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds error logging when sending serial commands, and upgrades the version of the
serialportlibrary.I don't remember which version of Node.js is running on this device. If it's 6.x or newer, we can upgrade
serialportagain: https://github.com/EmergingTechnologyAdvisors/node-serialport#for-which-version-of-node-serialport-would-you-like-documentation