Deprecate QUIT #11439
Deprecate QUIT #11439
Conversation
enjoy-binbin
left a comment
enjoy-binbin
left a comment
There was a problem hiding this comment.
we also need to run the generate-command-code.py
| "arity": -1, | ||
| "function": "quitCommand", | ||
| "deprecated_since": "7.2.0", | ||
| "replaced_by": "just closing the connection", |
There was a problem hiding this comment.
@guybe7 did we have any plans for replaced_by to always point to a specific command (rather than just plain text)?
There was a problem hiding this comment.
we don't rely on it, but i'd rather replaced_by would always be a command name
There was a problem hiding this comment.
Currently, it is a string of text usually with some commands embedded within it. I think we should follow that until we change it for all commands. Some examples:
georadius_ro.json: "replaced_by": "`GEOSEARCH` with the `BYRADIUS` argument",
georadiusbymember.json: "replaced_by": "`GEOSEARCH` and `GEOSEARCHSTORE` with the `BYRADIUS` and `FROMMEMBER` arguments",
georadiusbymember_ro.json: "replaced_by": "`GEOSEARCH` with the `BYRADIUS` and `FROMMEMBER` arguments",
On the redis.io website, it is rendered inside a sentence so we need to take care that the grammar ends up correct:
As of Redis version {deprecated_since}, this command is regarded as deprecated.
It can be replaced by {replaced_by} when migrating or writing new code.
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
approved in a core-team meeting for 7.2.
@zuiderkwast can you make a PR for redis-docs with the content Yossi mentioned in #11420
oranagra
added
state:needs-doc-pr
Done. I'm not sure how much detail to include in the docs apart from "don't use it", so feel free to edit the docs it before doc merge. |
Clients should not use this command. Instead, clients should simply close the connection when they're not used anymore. Terminating a connection on the client side is preferable, as it eliminates `TIME_WAIT` lingering sockets on the server side.
Clients should not use this command. Instead, clients should simply close the connection when they're not used anymore. Terminating a connection on the client side is preferable, as it eliminates `TIME_WAIT` lingering sockets on the server side.
4 participants
Fixes #11420.