Skip to content

Conversation

@htemelski
Copy link

@htemelski htemelski commented Apr 8, 2025

Adding the option for disabling slots refresh by setting the slotsRefreshInterval option to a negative value, similar to 370fa62#diff-bf62b2774a434c4a07716686a3c1fbd23368a673a7633622bdf1a9a9cd087de5
Backported bugfix: when refreshSlotsCache is called concurrently, call the callback only when the refresh process is done #1881

@elena-kolevska
Copy link
Contributor

I guess this should go to the v4 branch?

@htemelski htemelski changed the base branch from branch_v4.29.1 to v4 April 9, 2025 06:20
Copy link

@nkaradzhov nkaradzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@elena-kolevska
Copy link
Contributor

Please update the docs about the '-1' value

@htemelski htemelski changed the title Added the option for disabling slots refresh fix: added the option for disabling slots refresh, fixed concurrent calls to refreshSlotsCache Apr 9, 2025
Copy link
Contributor

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htemelski htemelski changed the title fix: added the option for disabling slots refresh, fixed concurrent calls to refreshSlotsCache feat: added the option for disabling slots refresh, fixed concurrent calls to refreshSlotsCache Apr 9, 2025
@htemelski htemelski merged commit 3ef36dc into v4 Apr 11, 2025
6 checks passed
@htemelski htemelski deleted the disable_sri branch April 11, 2025 08:30
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
# [4.30.0](v4.29.1...v4.30.0) (2025-04-11)

### Features

* added the option for disabling slots refresh, fixed concurrent calls to refreshSlotsCache ([#1972](#1972)) ([3ef36dc](3ef36dc))
@github-actions
Copy link

🎉 This PR is included in version 4.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants