Skip to content

Update Python 3.13 compatibility#199

Merged
vladvildanov merged 1 commit intoredis:masterfrom
DeD1rk:update-python-3.13-compatibility
Nov 18, 2024
Merged

Update Python 3.13 compatibility#199
vladvildanov merged 1 commit intoredis:masterfrom
DeD1rk:update-python-3.13-compatibility

Conversation

@DeD1rk
Copy link
Copy Markdown
Contributor

@DeD1rk DeD1rk commented Oct 19, 2024

Fixes #186

Updates CI to build cp313 wheels. Adds pypy-3.10 testing as well.

See also #174.

@chayim could you take a look?

Fixes redis#186

Updates CI to build cp313 wheels.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/redis/hiredis-py/issues/186?shareId=XXXX-XXXX-XXXX-XXXX).
@DeD1rk DeD1rk marked this pull request as ready for review October 19, 2024 08:59
@DeD1rk
Copy link
Copy Markdown
Contributor Author

DeD1rk commented Oct 19, 2024

Update: I now see https://github.com/redis/hiredis-py/pull/198/files, so my comment below doesn't really apply.

As a sidenote, CHANGELOG.md doesn't match the release notes any more. So perhaps it's time to drop it, or update it up to a certain version and indicate that from then on, the github release notes server as changelog. If you agree I'm happy to make those changes of course.

@junoriosity
Copy link
Copy Markdown

@DeD1rk @badboy @pietern @jparise @banker Is there some progress on that issue, as it would be terrific to allow it for Python 3.13. 🙂

@badboy
Copy link
Copy Markdown
Contributor

badboy commented Nov 3, 2024

I don't maintain this project anymore.

@Zaczero
Copy link
Copy Markdown

Zaczero commented Nov 4, 2024

I think maintainers moved to valkey or something 😬

@chayim
Copy link
Copy Markdown
Contributor

chayim commented Nov 17, 2024

@vladvildanov you

@vladvildanov
Copy link
Copy Markdown
Collaborator

Thanks @chayim for pinging me!

Guys just tag me on the PR's if you need a review

@vladvildanov vladvildanov merged commit 4113c71 into redis:master Nov 18, 2024
@hxyannay
Copy link
Copy Markdown

hxyannay commented Dec 2, 2024

Hey @vladvildanov could you cut a new release for hi-redis so there would be python 3.13 wheels in pypi?

@vladvildanov
Copy link
Copy Markdown
Collaborator

@hxyannay Hey! Planned later this week

@vladvildanov
Copy link
Copy Markdown
Collaborator

@hxyannay Already available

@hxyannay
Copy link
Copy Markdown

hxyannay commented Dec 4, 2024

Hey @vladvildanov
I see that you released v3.1.0, but I do not see it under pypi here: https://pypi.org/simple/hiredis/
Also I see that the latest github action run failed on publishing to pypi, so maybe that's the cause.

@vladvildanov
Copy link
Copy Markdown
Collaborator

@hxyannay FIxed

@hxyannay
Copy link
Copy Markdown

hxyannay commented Dec 5, 2024

Thank you @vladvildanov 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiredis cannot be installed on Python 3.13

7 participants