Redisotel: tracing Filter with ctx#3792
Open
Udhayarajan wants to merge 3 commits intoredis:masterfrom
Open
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has one of the approach mentioned in #3760. With ability to propagate all the params we got in Dial, Process, Pipeline hook.
Making it fully flexible for filtering the trace.
Note
Low Risk
Low risk: changes are localized to redis OpenTelemetry hook filtering and are backward-compatible via deprecated wrapper options, with updated/expanded tests covering the new behavior.
Overview
Adds context-aware filtering to redis OpenTelemetry tracing by changing
filterDial,filterProcess, andfilterProcessPipelineto acceptcontext.Context, and wiring that context throughDialHook,ProcessHook, andProcessPipelineHook.Introduces new options
WithDialFilterCtx,WithCommandFilterCtx, andWithCommandsFilterCtx, while deprecating the oldWithDialFilter,WithCommandFilter, andWithCommandsFiltervia wrappers; tests are renamed/updated and new cases verify filtering decisions based on values stored incontext.Reviewed by Cursor Bugbot for commit 36adcfe. Bugbot is set up for automated code reviews on this repo. Configure here.