Skip to content

Redisotel: tracing Filter with ctx#3792

Open
Udhayarajan wants to merge 3 commits intoredis:masterfrom
Udhayarajan:fix/tracing-with-ctx
Open

Redisotel: tracing Filter with ctx#3792
Udhayarajan wants to merge 3 commits intoredis:masterfrom
Udhayarajan:fix/tracing-with-ctx

Conversation

@Udhayarajan
Copy link
Copy Markdown
Contributor

@Udhayarajan Udhayarajan commented Apr 24, 2026

This PR has one of the approach mentioned in #3760. With ability to propagate all the params we got in Dial, Process, Pipeline hook.

Making it fully flexible for filtering the trace.

Note

Low Risk
Low risk: changes are localized to redis OpenTelemetry hook filtering and are backward-compatible via deprecated wrapper options, with updated/expanded tests covering the new behavior.

Overview
Adds context-aware filtering to redis OpenTelemetry tracing by changing filterDial, filterProcess, and filterProcessPipeline to accept context.Context, and wiring that context through DialHook, ProcessHook, and ProcessPipelineHook.

Introduces new options WithDialFilterCtx, WithCommandFilterCtx, and WithCommandsFilterCtx, while deprecating the old WithDialFilter, WithCommandFilter, and WithCommandsFilter via wrappers; tests are renamed/updated and new cases verify filtering decisions based on values stored in context.

Reviewed by Cursor Bugbot for commit 36adcfe. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented Apr 24, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@Udhayarajan Udhayarajan changed the title Fix/tracing with ctx Redisotel: tracing Filter with ctx Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant