Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Closed
4 tasks
elena-kolevska
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3772
wrappedOnCloseis not needed for theConnobject. Add a detailed comments on the user for future help of developers.Also make sure client onClose is implemented in such a way, so similar leak should not happen.
Note
Medium Risk
Touches core connection/client close paths and hook invocation semantics, which could affect cleanup ordering and error propagation. The change is well-contained and reinforced by extensive new regression/concurrency tests.
Overview
Fixes a resource leak caused by repeatedly wrapping
baseClientclose logic (issue #3772) by replacing the singleonClose func() errorwith a bounded, concurrency-safeonCloseHooksregistry where re-registering the same hook id replaces the prior callback.Moves streaming-credentials unsubscription from client-level close hooks to per-connection
pool.Conn.SetOnClose, and documents the required idempotent semantics forStreamingCredentialsProvider.Subscribe/UnsubscribeFuncto avoid leaks across connection re-inits.Updates sentinel failover and ring-shard cleanup to use the new named-hook registry, and adds focused tests covering hook ordering/replacement/error handling/concurrency plus a regression test modeling EntraID-style providers.
Reviewed by Cursor Bugbot for commit a337f4b. Bugbot is set up for automated code reviews on this repo. Configure here.