refactor(pool): remove redundant Conn.closed atomic field#3783
Merged
ndyakov merged 2 commits intoredis:masterfrom Apr 21, 2026
Merged
refactor(pool): remove redundant Conn.closed atomic field#3783ndyakov merged 2 commits intoredis:masterfrom
ndyakov merged 2 commits intoredis:masterfrom
Conversation
The closed field was redundant with stateMachine's StateClosed state. Now IsClosed() and Close() only use the state machine for consistency.
538ac5f to
33d30e7
Compare
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closed field was redundant with stateMachine's StateClosed state. Now IsClosed() and Close() only use the state machine for consistency.
Note
Low Risk
Small refactor that consolidates close-state tracking to the existing state machine; minimal behavioral change but could affect edge cases if any code relied on the atomic flag being set independently of state transitions.
Overview
Removes the redundant
Conn.closedatomic field fromConnand eliminates all reads/writes to it.Conn.IsClosed()andConn.Close()now rely exclusively on the state machine (StateClosed) to determine and mark closed status, ensuring a single source of truth for connection closure.Reviewed by Cursor Bugbot for commit 09edbfc. Bugbot is set up for automated code reviews on this repo. Configure here.