feat(csc): add command key extraction and caching logic#3773
Open
ofekshenawa wants to merge 3 commits intoadd-local-cachefrom
Open
feat(csc): add command key extraction and caching logic#3773ofekshenawa wants to merge 3 commits intoadd-local-cachefrom
ofekshenawa wants to merge 3 commits intoadd-local-cachefrom
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
46a7293 to
6f9063c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62bfb07. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Additive, currently-unused helper logic plus unit tests; main risk is future caching correctness if key extraction misses edge-case command argument layouts.
Overview
Adds initial client-side caching (CSC) command utilities: an allow-list of cacheable read-only commands,
isCacheablegating on both allow-list membership and presence of keys, andbuildCacheKeywhich generates length-prefixed cache keys to avoid argument-collision issues.Also introduces
extractRedisKeysto derive the Redis key(s) affected by supported commands (including multi-key,numkeys-style,JSON.MGET, andXREADlayouts), plus comprehensive unit tests covering cacheability decisions, cache-key determinism/collision safety, and key extraction edge cases.Reviewed by Cursor Bugbot for commit 50fa024. Bugbot is set up for automated code reviews on this repo. Configure here.