Skip to content

chore(tests): Add comprehensive TLS tests and example#3681

Merged
ndyakov merged 19 commits intomasterfrom
ndyakov/tls-tests
Feb 12, 2026
Merged

chore(tests): Add comprehensive TLS tests and example#3681
ndyakov merged 19 commits intomasterfrom
ndyakov/tls-tests

Conversation

@ndyakov
Copy link
Copy Markdown
Member

@ndyakov ndyakov commented Jan 20, 2026

Only the certificate authentication test skips (feature not yet supported). All other TLS tests will fail if TLS infrastructure is not properly configured.

Comment thread example/tls-connection/main.go Dismissed
Comment thread example/tls-connection/main.go Dismissed
@ndyakov ndyakov force-pushed the ndyakov/tls-tests branch 4 times, most recently from f46e8c9 to 7bee9bc Compare January 20, 2026 17:55
- cmdSlot now returns -1 for keyless commands instead of RandomSlot()
- This allows cmdNodeWithShardPicker to use the configured ShardPicker
  (default: RoundRobinPicker) for keyless command routing
- Updated mapCmdsByNode to handle slot == -1 by using ShardPicker
- Updated test to verify round robin distribution works correctly
@ndyakov ndyakov requested a review from ofekshenawa January 26, 2026 12:06
ofekshenawa
ofekshenawa previously approved these changes Jan 26, 2026
Copy link
Copy Markdown
Collaborator

@ofekshenawa ofekshenawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread example/tls-cert-auth/main.go Dismissed
Comment thread docker-compose.yml
Copy link
Copy Markdown
Collaborator

@ofekshenawa ofekshenawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread .github/workflows/test-redis-enterprise.yml Outdated
Comment thread tls_standalone_test.go Outdated
Comment thread example/tls-cert-auth/README.md
Comment thread docker-compose.yml Outdated
@ndyakov ndyakov merged commit f25343d into master Feb 12, 2026
39 checks passed
@ndyakov ndyakov deleted the ndyakov/tls-tests branch February 12, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants