Skip to content

Conversation

@pawelangelow
Copy link
Contributor

@pawelangelow pawelangelow commented Dec 3, 2025

What

Fix info icons to display tooltips on hover instead of requiring a click.

Replaced RiPopover (click-triggered) with RiTooltip (hover-triggered) for info icons in:

  • CreateRedisearchIndex: Identifier info icon
  • SubscribeInformation: Pub/Sub channel info icon
  • RemoveListElements: Redis version limitation info icon

Testing

  1. Navigate to Browser → Search by Values of Keys → Create Index panel → hover on the info icon next to "Identifier"
  2. Navigate to Pub/Sub page → hover on the info icon next to the channel input
  3. Connect to Redis < 6.2 → Open a List key → Remove elements panel → hover on the info icon

All info icons should now display their tooltips on hover.


Closes #RI-7811


Pull Request opened by Augment Code with guidance from the PR author


Note

Show info tooltips on hover (RiTooltip) instead of click (RiPopover) in create index, list removal, and pub/sub; update tests accordingly.

  • UI:
    • Replace RiPopover with RiTooltip for info icons (hover-triggered):
      • browser/components/create-redisearch-index/CreateRedisearchIndex.tsx (Identifier info)
      • browser/modules/key-details/.../RemoveListElements.tsx (Redis version limitation info)
      • pub-sub/components/subscribe-information/SubscribeInformation.tsx (channel/pattern info)
    • Remove popover state/handlers tied to info icons; keep confirmation popover for remove action.
  • Tests:
    • Update pub-sub/components/subscribe-information/SubscribeInformation.spec.tsx to assert tooltip on hover using waitForRiTooltipVisible.

Written by Cursor Bugbot for commit 116c7af. This will update automatically on new commits. Configure here.

Replace RiPopover with RiTooltip for info icons to display on hover
instead of requiring a click.

Affected components:
- CreateRedisearchIndex: Identifier info icon
- SubscribeInformation: Pub/Sub channel info icon
- RemoveListElements: Redis version limitation info icon

References: #RI-7811
@pawelangelow pawelangelow force-pushed the fe/bugfix/RI-7811-info-icons-hover branch from 68d0d44 to 0c4e834 Compare December 3, 2025 13:43
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.9% 21018/25352
🟡 Branches 68.05% 8846/12999
🟡 Functions 78.09% 5756/7371
🟢 Lines 83.31% 20584/24709

Test suite run success

5468 tests passing in 703 suites.

Report generated by 🧪jest coverage report action from 116c7af

Copy link
Contributor

@pd-redis pd-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it makes sense here, but there is this component in redis-ui:
https://redislabsdev.github.io/redis-ui/?path=/docs/components-moreinfoicon--docs

It definitely goes on the tooltip route.

I however agree with the chatbot, that interactive contents in tooltip can be hard to interact with.


{!canRemoveMultiple ? (
<FlexItem>{InfoBoxPopover()}</FlexItem>
<FlexItem>{InfoBoxTooltip()}</FlexItem>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this calling a component as a fuinction?!?!?!

</RiPopover>
<Text>
Supported glob-style patterns are described&nbsp;
<Link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, link chacing

Tooltips containing clickable links need interactive mode
to allow users to hover over the tooltip content and click
the links before it disappears.

References: #RI-7811
@pawelangelow pawelangelow merged commit 2a59a92 into main Dec 4, 2025
19 checks passed
@pawelangelow pawelangelow deleted the fe/bugfix/RI-7811-info-icons-hover branch December 4, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants