-
Notifications
You must be signed in to change notification settings - Fork 427
RI-7811 Show info icon tooltips on hover instead of click #5297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace RiPopover with RiTooltip for info icons to display on hover instead of requiring a click. Affected components: - CreateRedisearchIndex: Identifier info icon - SubscribeInformation: Pub/Sub channel info icon - RemoveListElements: Redis version limitation info icon References: #RI-7811
redisinsight/ui/src/pages/browser/components/create-redisearch-index/CreateRedisearchIndex.tsx
Show resolved
Hide resolved
68d0d44 to
0c4e834
Compare
Code Coverage - Frontend unit tests
Test suite run success5468 tests passing in 703 suites. Report generated by 🧪jest coverage report action from 116c7af |
pd-redis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it makes sense here, but there is this component in redis-ui:
https://redislabsdev.github.io/redis-ui/?path=/docs/components-moreinfoicon--docs
It definitely goes on the tooltip route.
I however agree with the chatbot, that interactive contents in tooltip can be hard to interact with.
redisinsight/ui/src/pages/browser/components/create-redisearch-index/CreateRedisearchIndex.tsx
Show resolved
Hide resolved
|
|
||
| {!canRemoveMultiple ? ( | ||
| <FlexItem>{InfoBoxPopover()}</FlexItem> | ||
| <FlexItem>{InfoBoxTooltip()}</FlexItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this calling a component as a fuinction?!?!?!
| </RiPopover> | ||
| <Text> | ||
| Supported glob-style patterns are described | ||
| <Link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, link chacing
Tooltips containing clickable links need interactive mode to allow users to hover over the tooltip content and click the links before it disappears. References: #RI-7811
What
Fix info icons to display tooltips on hover instead of requiring a click.
Replaced
RiPopover(click-triggered) withRiTooltip(hover-triggered) for info icons in:Testing
All info icons should now display their tooltips on hover.
Closes #RI-7811
Pull Request opened by Augment Code with guidance from the PR author
Note
Show info tooltips on hover (RiTooltip) instead of click (RiPopover) in create index, list removal, and pub/sub; update tests accordingly.
RiPopoverwithRiTooltipfor info icons (hover-triggered):browser/components/create-redisearch-index/CreateRedisearchIndex.tsx(Identifier info)browser/modules/key-details/.../RemoveListElements.tsx(Redis version limitation info)pub-sub/components/subscribe-information/SubscribeInformation.tsx(channel/pattern info)pub-sub/components/subscribe-information/SubscribeInformation.spec.tsxto assert tooltip on hover usingwaitForRiTooltipVisible.Written by Cursor Bugbot for commit 116c7af. This will update automatically on new commits. Configure here.