RI-7832 Replace open book with open folder icon in the Tutorials #5262
Conversation
tptodorov
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
|
|
Code Coverage - Frontend unit tests
Test suite run success5424 tests passing in 703 suites. Report generated by 🧪jest coverage report action from 38ffec8 |
- Remove custom SVG file folder_open.svg - Remove FolderOpenIcon import/export from iconRegistry.tsx - Update @redis-ui/icons to version 6.3.17 which includes FolderOpenIcon - Fix icon logic in Group component to show FolderOpenIcon when open References: #RI-7832
…t and icon usage - Added guidelines for clearing Vite cache after updating npm packages - Emphasized the use of Redis UI icons and provided instructions for icon usage and exceptions for custom icons
valkirilov
changed the title
| "@elastic/eui": "34.6.0", | ||
| "@redis-ui/components": "^39.18.0", | ||
| "@redis-ui/icons": "^6.1.1", | ||
| "@redis-ui/icons": "^6.3.17", |
There was a problem hiding this comment.
last bump was 2 months ago, I assume no breaking changes happened (e.g. no icons we use was removed)?
There was a problem hiding this comment.
tl;dr - I hope so.
It's a valid concern, so I went trough their release logs, and it seems they didn't change anything major (or at least they didn't mention it).
Still, we have the option to postpone this PR after the release, since it's something minor, so we don't risk it.
What
Replace the "open book" with an "open folder" icon, in the Tutorials panel.
Please check that it has used the right open folder icon.
Testing
Open the existing tutorials and see how the folder icon changes.
Note
Adds a new
folder_open.svgicon, registers it asFolderOpenIcon, and uses it in enablement group headers when expanded.EnablementArea/components/Group/Group.tsxto showFolderOpenIconwhen the group is expanded (fallback remainsFolderIconwhen collapsed).ui/src/assets/img/icons/folder_open.svg.FolderOpenIconincomponents/base/icons/iconRegistry.tsx.Written by Cursor Bugbot for commit 7da0139. This will update automatically on new commits. Configure here.